conda-forge / wetterdienst-feedstock

A conda-smithy repository for wetterdienst.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Only use - backports-datetime-fromisoformat >=2.0.0,<3.0.0 # [py<311] #101

Closed kmuehlbauer closed 1 year ago

kmuehlbauer commented 1 year ago

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

kmuehlbauer commented 1 year ago

Gnarf, currently the Python 3.11 envs are broken due to this.

@conda-forge-admin, please rerender

kmuehlbauer commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/wetterdienst-feedstock/actions/runs/6221308430.

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/wetterdienst-feedstock/actions/runs/6221317428.

xylar commented 1 year ago

@kmuehlbauer, this would require us dropping noarch: python. It is also not consistent with the upstream repo. So it would need to be changed there first. But I think we really don't want to move away from noarch: python unless we absolutely have to. I don't know of a a way to avoid building a separate package for each OS and python version when we do that, so the number of builds goes from 1 to 20 (assuming all 5 architectures and all 4 python versions are supported).

kmuehlbauer commented 1 year ago

I'm stuck with 0.56.2 at Python 3.11 since backports-datetime-fromisoformat works only for python versions < 3.11:

Encountered problems while solving:
  - package wetterdienst-0.60.0-pyhd8ed1ab_0 requires backports-datetime-fromisoformat >=2.0.0,<3.0.0, but none of the providers can be installed

The environment can't be solved, aborting the operation

And 0.56.2 is only installable with --no-deps to not downgrade pandas etc.

The strict pinning throughout the dependencies is becoming a major pain point to use wetterdienst on conda-forge in a user-friendly fashion.

kmuehlbauer commented 1 year ago

@xylar I totally agree here to not move to noarch. But we would need some workaround to at least get this installed somehow.

xylar commented 1 year ago

@kmuehlbauer, I see. That's a problem. Let's try to fix it at: https://github.com/conda-forge/backports-datetime-fromisoformat-feedstock/issues/11

kmuehlbauer commented 1 year ago

Thanks @xylar! That's the minimum intrusive action to take.

xylar commented 1 year ago

I think https://github.com/conda-forge/backports-datetime-fromisoformat-feedstock/pull/12 is the "right" fix.

kmuehlbauer commented 1 year ago

Thanks @xylar and @ocefpaf!

amotl commented 1 year ago

Hi there,

I was probably running into the same problems at GH-102, however I didn't investigate closer if it is exactly the same, by reading up on your conversation thoroughly.

I just wanted to inform you about it, and that I opened GH-105, in order to verify the situation again, where you may want to add corresponding fixes again, if you know how to fix this better. Apologies if I did anything wrong, by not known it better, and only discovering your conversation afterwards.

With kind regards, Andreas.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.