conda-forge / wetterdienst-feedstock

A conda-smithy repository for wetterdienst.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

wetterdienst v0.61.0 #102

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6435257567, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 1 year ago

Looks like eccodes >=1.5.2,<1.7 doesn't exist (yet?). I don't have time to look into this right now. Maybe someone else does?

amotl commented 1 year ago

Oh I see, there is the same game here as with having conversations with GitHub Actions, or any other CI system on this planet.

The reported errors are:

  • Encountered problems while solving:
    • nothing provides requested eccodes >=1.5.2,<1.7

-- https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=798472&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=255

amotl commented 1 year ago

Looks like eccodes >=1.5.2,<1.7 doesn't exist (yet?). I don't have time to look into this right now. Maybe someone else does?

Sure, we will look into it. Maybe tomorrow or afterwards. Thanks again for refreshing the dependencies so quickly, we will build upon it, fixing this forward.

amotl commented 1 year ago

Apparently, the eccodes package on conda-forge employs a different versioning scheme than the original package on PyPI. It looks like vanilla version 1.6.1, released on Oct 2, 2023, corresponds to the conda-forge version 2.32.0, released on Oct 4, 2023.

amotl commented 1 year ago

It looks like the correct conda-forge package to select, would be python-eccodes. Its release history contains also shows version 1.6.1 as the most recent one. f720684d3b adds a corresponding fix to this patch.

amotl commented 1 year ago

Observation

The next flaw is this one:

+ wetterdienst --help
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/wetterdienst_1696622209000/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/bin/wetterdienst", line 7, in <module>
    from wetterdienst.ui.cli import cli
  File "/home/conda/feedstock_root/build_artifacts/wetterdienst_1696622209000/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.11/site-packages/wetterdienst/ui/cli.py", line 19, in <module>
    from wetterdienst.ui.core import (
  File "/home/conda/feedstock_root/build_artifacts/wetterdienst_1696622209000/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.11/site-packages/wetterdienst/ui/core.py", line 9, in <module>
    from wetterdienst.core.process import create_date_range
  File "/home/conda/feedstock_root/build_artifacts/wetterdienst_1696622209000/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.11/site-packages/wetterdienst/core/process.py", line 8, in <module>
    from backports.datetime_fromisoformat import MonkeyPatch
  File "/home/conda/feedstock_root/build_artifacts/wetterdienst_1696622209000/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.11/site-packages/backports/datetime_fromisoformat/__init__.py", line 4, in <module>
    from backports._datetime_fromisoformat import date_fromisoformat, datetime_fromisoformat, time_fromisoformat, FixedOffset
ModuleNotFoundError: No module named 'backports._datetime_fromisoformat'

-- https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=798486&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=362

Thoughts

I can't understand it, because backports-datetime-fromisoformat >=2,<3 is still part of the list of dependencies within meta.yaml.

amotl commented 1 year ago

After discovering https://github.com/movermeyer/backports.datetime_fromisoformat/issues/25, and that there are two files about version 2.0.0 on https://anaconda.org/conda-forge/backports-datetime-fromisoformat/files, I looked at the Azure Pipeline output, and found that the most recent 2.0.0-pyh0c530f3_1 has been selected for installation.

This package file was just uploaded recently, specifically 18 days and 7 hours ago.

This package file already exists since 7 months and 5 days ago.

Maybe the most recent one is broken due to some reason? Is there a way to explicitly select the previous one?

amotl commented 1 year ago

Maybe the most recent one, 2.0.0-pyh0c530f3_1 is broken due to some reason? Is there a way to explicitly select the previous one?

946f0e0e3535 explicitly selects the previous 2.0.0-pyh71feb2d_0, and indeed, it works.

amotl commented 1 year ago

It looks like backports-datetime-fromisoformat: 2.0.0-pyh0c530f3_1 is the outcome of https://github.com/conda-forge/backports-datetime-fromisoformat-feedstock/pull/12, coming from discussions at https://github.com/conda-forge/wetterdienst-feedstock/pull/101.

Apologies if I made any mistakes on this matter, by fixing it here through downgrading to the previous version. After the CI signaled "green state", I assumed everything would be all right.

GH-105 will re-explore the situation accordingly.