conda-forge / wetterdienst-feedstock

A conda-smithy repository for wetterdienst.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Add @xylar as repository maintainer/owner #78

Closed amotl closed 1 year ago

amotl commented 1 year ago

Comment:

Dear @kmuehlbauer,

@xylar reported at https://github.com/conda-forge/wetterdienst-feedstock/pull/76#issuecomment-1333636478, that he still does not have appropriate permissions. It looks like @amotl (myself) also lacks corresponding permissions on the GitHub repository itself, e.g. for being able to adjust the project's settings, like editing branch protection rules, and such.

Maybe you can add our trio @gutzbenj, @xylar and myself, @amotl, as repository owners as well?

With kind regards, Andreas.

kmuehlbauer commented 1 year ago

@amotl I'm missing the settings tab too.

kmuehlbauer commented 1 year ago

@conda-forge-admin, update team

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I updated the team with maintainers from main.

kmuehlbauer commented 1 year ago

@amotl @xylar I'm not sure what's going on here. But this is what I found:

I have the settings tab on one feedstock which was generated in the early stages of conda-forge. I have the "settings" tab there. Here or in other (more recent) feedstocks I do not see the "seetings" tab. That's beyond my understanding. We might need to ask @conda-forge/core about that.

amotl commented 1 year ago

Thanks for investigating, Kai. Maybe not having elevated repository permissions is fine after all, and everything we are allowed to do is protected by corresponding bot commands.

How is the situation with you, @xylar? Do you happen to have more privileges on other feedstock repositories as well? If yes, how did you get them?

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I rerendered the recipe in conda-forge/wetterdienst-feedstock#79.

xylar commented 1 year ago

@amotl, yes, I have a settings tab with the usual options when I go to my fork: https://github.com/xylar/wetterdienst-feedstock/settings This was just created a few days ago so I don't think it would be different for other feedstocks.

I believe the permissions on https://github.com/earthobservations/wetterdienst-feedstock might be different because it belongs to an organization, not an individual user, and must be maintained by the organization admins or individual repo admins that are set up by the organization admins. I don't think conda-forge can set permissions for maintainers on such forks in the same way, but I could be wrong.

hmaarrfk commented 1 year ago

Hmm, you should all be able to write: image

This seems to be the same as what other teams have on other repos. image

xylar commented 1 year ago

It could also be that an admin on https://github.com/earthobservations has to accept some kind of an invitation to collaborate before conda-forge can set permissions.

xylar commented 1 year ago

@hmaarrfk, the issue isn't on this repo, its on the fork https://github.com/earthobservations/wetterdienst-feedstock. Typically, maintainers can edit branches on each other's forks but I can't edit branches on that fork.

hmaarrfk commented 1 year ago

i think this is a known limitation of using orgs on github. or at least jakirkham told me that.

xylar commented 1 year ago

Thanks, that sounds consistent with my experience in the past, too.