search

conda-forge / wgrib2-feedstock

A conda-smithy repository for wgrib2.
BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

V2.0.8 #12

Closed ocefpaf closed 4 years ago

ocefpaf commented 4 years ago

Closes #11

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 4 years ago

Looks like the compiler does not like values > 0 for USE_IPOLATES:

Config.c: In function 'f_config':
Config.c:83:18: error: operator '>' has no left operand
 #if USE_IPOLATES > 0
                  ^
make: *** [Config.o] Error 1
Traceback (most recent call last):
conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

akrherz commented 4 years ago

I attempted to debug this locally and could not reproduce the Azure failure. Would setting #define USE_IPOLATES 3 in config.h be an acceptable solution hack around this problem?

ocefpaf commented 4 years ago

I attempted to debug this locally and could not reproduce the Azure failure. Would setting #define USE_IPOLATES 3 in config.h be an acceptable ~solution~ hack around this problem?

Sure. Do you want to send a PR? And add yourself as a maintainer too ;-p

PS: I'm slow to respond these days and I don't have much time for wgrib2. We added this for a 1-time project and people at my day job don't use it that much.