conda-forge / wgrib2-feedstock

A conda-smithy repository for wgrib2.
BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Rebuild for jasper4 #28

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update jasper4.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4421958847, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

akrherz commented 1 year ago

Hmmm, boggling...

ld: cannot find -lgrib2c: No such file or directory

akrherz commented 1 year ago

@conda-forge-admin please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/wgrib2-feedstock/actions/runs/4567365280.

akrherz commented 1 year ago

@conda-forge-admin please restart ci

akrherz commented 1 year ago

OK, conda-forge/g2clib-feedstock#26 changes at play here.

akrherz commented 1 year ago

Now we are at

gnu/11.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: enc_jpeg2000_clone.o: in function `enc_jpeg2000_clone':
2023-03-30T18:03:10.4582432Z enc_jpeg2000_clone.c:(.text.enc_jpeg2000_clone+0x137): undefined reference to `jpc_encode'
2023-03-30T18:03:11.4406240Z /home/conda/feedstock_root/build_artifacts/wgrib2_1680199183107/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/11.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: unpk.o: in function `unpk_grib':
2023-03-30T18:03:11.4451875Z unpk.c:(.text.unpk_grib+0x7ac): undefined reference to `jpc_decode'
2023-03-30T18:03:11.4452856Z collect2: error: ld returned 1 exit status
2023-03-30T18:03:11.4453628Z make: *** [makefile:25: wgrib2] Error 1
akrherz commented 1 year ago

now I think we are here: NOAA-EMC/NCEPLIBS-g2c#245

akrherz commented 1 year ago

could @edwardhartnett kindly comment if wgrib2 supports jasper 4 ? TIA

akrherz commented 1 year ago

kind ping to @zklaus, if you have thoughts on this PR?

edwardhartnett commented 1 year ago

NOAA EMC does not support wgrib2 and we recommend it not be used in operational products.

For more info about wgrib2 see https://www.cpc.ncep.noaa.gov/products/wesley/wgrib2/.

zklaus commented 1 year ago

@conda-forge-admin, please restart ci

zklaus commented 1 year ago

The error above stems from the use of the Jasper internal function jpc_decode in g2clib. This was fixed in the latest version of g2clib (1.7.0), so let's see if a rebuild now solves the problem. If not, at least we'll get the logs back; they have vanished from the old build by now.

zklaus commented 1 year ago

I see now that wgrib2 has a clone of one file from g2c with a call to jpc_encode, which is why having a recent g2clib in the deps is not enough. I have prepared a minimal patch ready to be committed here. If you merge #29 I'll push it myself, if you prefer to just get the patch, let me know and I'll upload it.