conda-forge / xcape-feedstock

A conda-smithy repository for xcape.
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Rebuild for python312 #22

Open regro-cf-autotick-bot opened 8 months ago

regro-cf-autotick-bot commented 8 months ago

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6501924064, please use this URL for debugging.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

weiji14 commented 1 month ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

weiji14 commented 1 month ago

Builds are failing on Python 3.12, is some update needed upstream at https://github.com/xgcm/xcape? Asking because this is currently blocking the Python 3.12 upgrade on pangeo-docker-images.

Error message copied from https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=937300&view=logs&j=e9afaa34-1a0f-534e-78fc-fae528ccd915&t=869ab379-d63c-50ae-655f-69018fb07995&l=694:

Processing $SRC_DIR
  Added file://$SRC_DIR to build tracker '/tmp/pip-build-tracker-b42bquus'
  Running setup.py (path:$SRC_DIR/setup.py) egg_info for package from file://$SRC_DIR
  Created temporary directory: /tmp/pip-pip-egg-info-n6kouz3w
  Preparing metadata (setup.py): started
  Running command python setup.py egg_info
  /home/conda/feedstock_root/build_artifacts/xcape_1716040613415/work/versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
    LONG_VERSION_PY['git'] = '''
  Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "/home/conda/feedstock_root/build_artifacts/xcape_1716040613415/work/setup.py", line 8, in <module>
      from numpy.distutils.core import setup, Extension
  ModuleNotFoundError: No module named 'numpy.distutils'
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> See above for output.
ocefpaf commented 2 weeks ago

Most fortran extensions are broken in Python and the effort to fix them seems to be as much as re-writing things in numba, c, rust, etc. That's why people are kind of letting them go. I'm sad that there is not a clear migration path though. Some modules are still useful and unique and won't get a re-write anytime soon.

weiji14 commented 1 week ago

Ok, we've dropped xcape from pangeo-docker-images - https://github.com/pangeo-data/pangeo-docker-images/pull/556#discussion_r1650257208, but happy to add it back if someone does decide to pick up on maintenance again (or if someone ports it to Rust, that would be nice too!).

ocefpaf commented 1 week ago

Ok, we've dropped xcape from pangeo-docker-images - pangeo-data/pangeo-docker-images#556 (comment), but happy to add it back if someone does decide to pick up on maintenance again (or if someone ports it to Rust, that would be nice too!).

For a brief moment I thought that this issue was already solved 😄

https://github.com/xgcm/xcape/blob/master/src/xcape/cape_numba.py