Closed rabernat closed 4 years ago
It's not a conda-forge issue. If you just do pip install .
from the xcape repo, it produces the same layout. Probably best to continue with an issue over there?
Thanks for the suggestion @dopplershift! What you say sounds plausible. Whenever I install locally, I run pip install -e .
. That's also what we do in the xcape tests. I never anticipated that pip install .
would work any differently.
To test this myself, I just did
conda create -n xcape_env numpy xarray dask-core fortran-compiler python=3.7
pip install .
And I reproduced the problematic install.
Over in #4, @ocefpaf seems to have found a fix that does not involve touching our setup.py. But it seems like we should be able to pip install .
on the package, independently of conda-forge. Trying to figure out the best approach to fix.
And as usual @ocefpaf is 100 steps ahead of me: https://github.com/xgcm/xcape/pull/22
Yeah, we moved MetPy to use a src/
layout and making sure we do pip install .
in our tests to make sure we're testing as our users would install.
For the record, pip install -e .
is little more than a symlink to your python code (and a build of your extension code in-place). Great for development, not so great for testing.
The alternative is either the src
layout or not running the tests from the root directory. Both would catch that. I also do like to add some tarball tests, like check-manifest and twine checks, I'll add those to the PR.
I made some of these changes over in https://github.com/xgcm/xcape/pull/23 and issued a new release (0.1.1). Thanks for all your suggestions.
I guess we can close this one now. Please re-open if I'm wrong.
The package I install from conda-forge appears to be, for lack of a better word, empty. If I look in the directory where it was installed, I see the following
There is no
__init__.py
, and in fact there are no pyhton files at all. Just a few compiled modules. As a result, I can't import or use the modules from the package, i.e.Something is wrong with this build, but I can't figure out what. I guess setup.py is not running properly?
Help would be much appreciated.
Environment (
conda list
):Details about
conda
and system (conda info
):