search

conda-forge / xesmf-feedstock

A conda-smithy repository for xesmf.
BSD 3-Clause "New" or "Revised" License
5 stars 9 forks source link

fix xarray deps #12

Closed ocefpaf closed 3 years ago

ocefpaf commented 3 years ago

Addresses https://github.com/pangeo-data/xESMF/issues/57

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jthielen commented 3 years ago

Thank you @ocefpaf! It looks like this also supersedes https://github.com/conda-forge/xesmf-feedstock/pull/11.

ocefpaf commented 3 years ago

Actually I thought that release v0.5.0 had the != but it is <=, see https://github.com/pangeo-data/xESMF/blob/bb29347acd244ec7e3f9b50773d08a19803e4a16/setup.py#L22

@huard and @jthielen we probably need a new release then, no? Unless the pin was not OK in the current version to stat with.

jthielen commented 3 years ago

As a user I wouldn't mind either way forward, so I'll defer to @huard (and the other current xesmf maintainers @raphaeldussin and @andersy005?).

huard commented 3 years ago

v0.5.1 released

raphaeldussin commented 3 years ago

@huard we don't have the package for 0.5.1 only the sources (tar and zip) in assets. how do we fix this? sorry @ocefpaf I'll update the sha when we got this fixed

ocefpaf commented 3 years ago

@huard we don't have the package for 0.5.1 only the sources (tar and zip) in assets. how do we fix this? sorry @ocefpaf I'll update the sha when we got this fixed

Just did that manually, fixed the checksum, and I sent a PR to fix the error that prevented the package from being created. See https://github.com/pangeo-data/xESMF/pull/63

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!