Open regro-cf-autotick-bot opened 4 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
@conda-forge-admin, please re-render
@conda-forge-admin, please re-render
@conda-forge-admin, please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10174282202.
@conda-forge-admin , please re-render
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10176143912.
Looks like there is an issue finding Windows OpenMP on CI:
CMake Error at D:/bld/xgboost-split_1722411873928/_build_env/Library/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
-- Configuring incomplete, errors occurred!
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/10176776784.
@conda-forge-admin , please re-render
Thanks for working on this so far! β€οΈ
I just wanted to send a gentle nudge that it would be nice to see this resolved. Perhaps a motivator: xgboost
is currently the heaviest node that the migrator is waiting on to merge.
Without a Windows machine to debug the remaining errors, this is pretty hard to progress on. If there is someone with an interest in this and a Windows machine available, would encourage them to dive in
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/11027261294.
I think msvc doesn't handle the R C API header very well. It should be a commen issue for all r C extensions though, curious how others are doing.
Think we are using MinGW for R builds. That said, could very well have configuration issues that need updates in this PR
FWIW here is the current error on CI:
CMake Error at cmake/modules/FindLibR.cmake:48 (message):
dlltool.exe not found!
Do you have Rtools installed with its MinGW's bin/ in PATH?
Call Stack (most recent call first):
cmake/modules/FindLibR.cmake:167 (create_rlib_for_msvc)
R-package/CMakeLists.txt:1 (find_package)
The latest round of errors seem to indicate that the -lR
LDFLAG is missing on Windows. There is a Makevars.win
in the R-package subdirectory: https://github.com/dmlc/xgboost/blob/master/R-package/src/Makevars.win. However, this line in cmake/RPackageInstall.cmake.in
may imply that Makevars.win
is overwritten at build time: https://github.com/dmlc/xgboost/blob/8fe518600aad007dd5e50fecadd19ec44b15d235/cmake/RPackageInstall.cmake.in#L26.
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11586509586.
@conda-forge-admin , please re-render
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11586589229.
I made some progress here - in my local test I can get past the compilation failures now, though it gets stuck at later point now.
The two fixes that are needed are:
-DLIBR_CORE_LIBRARY=%PREFIX%\lib\R\bin\x64\R.lib
to the CMake arguments in install-r-xgboost.bat
# [not win]
comment after make
in meta.yaml in the build:
section in meta.yaml
under the r-xgboost
package section.I think the reason the first argument is needed is because CMake cannot find the R.lib
in our r-base
package and tries to make its own instead, which doesn't allow it to properly link the necessary symbols. If we provide the path to the correct R.lib
then it seems to work.
Thanks Daniel! π
Would you like to make a PR to this feedstock or the bot's fork's branch? π
Maybe other folks will have ideas on the next error once we have it in CI here where it is easy to look at
I'll go ahead and start new PR so I also have push access.
Sounds good. Thanks Daniel! π
Continued in PR: https://github.com/conda-forge/xgboost-feedstock/pull/196
This PR has been triggered in an effort to update r-base44_and_m2w64-ucrt.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.