conda-forge / xopen-feedstock

A conda-smithy repository for xopen.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

xopen v2.0.0 #37

Closed regro-cf-autotick-bot closed 5 months ago

regro-cf-autotick-bot commented 5 months ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8433703260, please use this URL for debugging.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

marcelm commented 5 months ago

@rhpvorderman I bumped the python-isal dependency and added zlib-ng. Do we still need the isa-l dependency? If it was only for igzip, then we can remove it, right?

rhpvorderman commented 5 months ago

Yes that is true. It can be removed. It will still be installed as a python-isal dependency, but that does not need to be replicated in the xopen recipe indeed.

rhpvorderman commented 5 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xopen-feedstock/actions/runs/8436196931.

marcelm commented 5 months ago

Builds are failing on linux-aarch64. The error messages are not helping, but I assume the problem is that python-zlib-ng isn’t available for that architecture.

rhpvorderman commented 5 months ago

I think your assumption is correct. I updated meta.yaml. A bit unfortunate for those processing WGS samples on their raspberry PIs, but I think those should be storage/network speed bottlenecked anyway.

It is a bit unfortunate that xopen can not be used as a pure python package in conda's system.

rhpvorderman commented 5 months ago

Aarch failures on python 3.9. That is odd.

rhpvorderman commented 5 months ago

I propose we merge anyway. If something is truly wrong, the aarch64 users are probably savvy enough to file a bug report. Then we can get a proper error. The python bindings I maintain get extensively tested on aarch64, so they should function correctly.

marcelm commented 5 months ago

If a PR with build failures is merged, will the non-failing packages still be uploaded?

rhpvorderman commented 5 months ago

I don't know. But if all fails, we can simply try again with a bumped build number. Failure is not catastrophic. So I will just hit the merge and see what happens.