conda-forge / xopen-feedstock

A conda-smithy repository for xopen.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

xopen v0.8.4 #5

Closed rhpvorderman closed 5 years ago

rhpvorderman commented 5 years ago

Checklist

Retry from autotick.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rhpvorderman commented 5 years ago

Strange. I can merge it on my own PC into master. Why does the merging not work all of a sudden?

marcelm commented 5 years ago

I think we are not supposed to use branches on the main feedstock repo for PRs. It seems you just published version 0.8.4 to anaconda.org already ...

Oh well, no harm done ... Should we just merge this now? Or will that trigger another deploy?

rhpvorderman commented 5 years ago

I think we are not supposed to use branches on the main feedstock repo for PRs. It seems you just published version 0.8.4 to anaconda.org already ...

Whoops! Did not realize that. Sorry!

Oh well, no harm done ... Should we just merge this now? Or will that trigger another deploy?

I think it won't build unless the build number has changed right? I will merge so master is correct. If anything breaks I will make a new PR with an increased build number.

rhpvorderman commented 5 years ago

I just realized that it might have autobuild because I had the keyword release in the branch name.

marcelm commented 5 years ago

I think "release" in the branch name does not matter if I interpret the docs correctly.

rhpvorderman commented 5 years ago

Thanks. Next time I will open a separate branch on my own fork.