Remove *.la files - Githubissues

conda-forge / xz-feedstock

A conda-smithy repository for xz.

BSD 3-Clause "New" or "Revised" License

0 stars 22 forks source link

Remove *.la files #18

Closed scopatz closed 6 years ago

scopatz commented 6 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

halldc commented 6 years ago

@scopatz I think this PR causes build failures for the imagemagick package. Could you help me understand why these libtool files needed to be removed?

scopatz commented 6 years ago

@halldc - sure thing - you can read up on this in the tracking issue: https://github.com/conda-forge/conda-forge.github.io/issues/621

You can also follow the links there for more info

scopatz commented 6 years ago

basically, all of imagemagick's dependencies also need to remove the *la files.

scopatz commented 6 years ago

And there is a suggestion that conda-build should do this automatically, but no one has written the PR for that yet :wink:

halldc commented 6 years ago

@scopatz Thanks for the explanation! This helped a lot