conda-forge / xz-feedstock

A conda-smithy repository for xz.
BSD 3-Clause "New" or "Revised" License
0 stars 22 forks source link

CFEP-18: Remove static libraries from main build #23

Closed xhochy closed 4 years ago

xhochy commented 4 years ago

This removes the static libraries from the main package according to CFEP-18. This might break some downstream builds but this is intended and we should fix the downstream builds to use the shared libraries before adding an output here.

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

scopatz commented 4 years ago

It looks like windows is failing

xhochy commented 4 years ago

@scopatz Can you have a look again. I stripped down the Windows build to what actually is run in the CI. Turns out we were'nt using the VC switches anymore in there.

scopatz commented 4 years ago

LGTM Thanks!