Closed xhochy closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
Documentation on acceptable licenses can be found here.
It looks like windows is failing
@scopatz Can you have a look again. I stripped down the Windows build to what actually is run in the CI. Turns out we were'nt using the VC switches anymore in there.
LGTM Thanks!
This removes the static libraries from the main package according to CFEP-18. This might break some downstream builds but this is intended and we should fix the downstream builds to use the shared libraries before adding an output here.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)