fix tests - Githubissues

conda-forge / xz-feedstock

A conda-smithy repository for xz.

BSD 3-Clause "New" or "Revised" License

0 stars 22 forks source link

Open isuruf opened 1 year ago

isuruf commented 1 year ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

isuruf commented 1 year ago

@ocefpaf, do you want to merge this with tests failing on windows, so that there are no more accidental broken uploads on windows?

ocefpaf commented 1 year ago

@ocefpaf, do you want to merge this with tests failing on windows, so that there are no more accidental broken uploads on windows?

Argh. Completely forgot about this one. I'm not sure what you mean there. The failing test is:

if not exist %PREFIX%\Library\bin\liblzma.dll

Was that renamed? Removed? Can we just remove that test?

isuruf commented 1 year ago

Was that renamed? Removed? Can we just remove that test?

You switched the build system in 5.2.9 and this file is missing due to that change.

ocefpaf commented 1 year ago

You switched the build system in 5.2.9 and this file is missing due to that change.

Ah! Now I remember. I don't recall why I changed though :-)