Closed msarahan closed 8 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Also this will need to be re-rendered with the newest conda-smithy
. This is necessary to enable AppVeyor support. To do so just do the following.
conda install -y -n root -c conda-forge conda-smithy
conda smithy rerender
Then add and commit all changes and push them back here.
Related to this issue ( https://github.com/conda-forge/xz-feedstock/issues/1 ).
Note that the update to 5.2.2 is mandatory: the VS solution files do not exist with 5.0.5.
If this is not the right time to update XZ to the newer version, just hold off on merging this PR.
It is. In fact we had that, I deleted due to the Python 3.4/3.5 issues, and I was going to re-add before https://github.com/conda-forge/staged-recipes/pull/370 gets merged.
So :+1:
Why AppVeyor was not triggered in this case?
Why AppVeyor was not triggered in this case?
The feedstock needs to be re-rendered so the - skip: True # [win]
change can propagate to the CI configuration. (Sorry I missed that before @msarahan and thanks @ccordoba12 for noticing it.)
You beat me, @ocefpaf, but I'm posting anyways. 😜
It needs to be re-rendered. We disable AppVeyor if there is skip: true # [win]
in the recipe.
To fix this, do the following.
conda install -y -n root -c conda-forge conda-smithy
conda smithy rerender
git add .
git commit -m "Re-rendered with conda-smithy x.x.x"
Note that the update to 5.2.2 is mandatory: the VS solution files do not exist with 5.0.5.
If this is not the right time to update XZ to the newer version, just hold off on merging this PR.