conda-forge / xz-feedstock

A conda-smithy repository for xz.
BSD 3-Clause "New" or "Revised" License
0 stars 22 forks source link

add windows vs 2015 build #4

Closed msarahan closed 8 years ago

msarahan commented 8 years ago

Note that the update to 5.2.2 is mandatory: the VS solution files do not exist with 5.0.5.

If this is not the right time to update XZ to the newer version, just hold off on merging this PR.

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 8 years ago

Also this will need to be re-rendered with the newest conda-smithy. This is necessary to enable AppVeyor support. To do so just do the following.

conda install -y -n root -c conda-forge conda-smithy
conda smithy rerender

Then add and commit all changes and push them back here.

jakirkham commented 8 years ago

Related to this issue ( https://github.com/conda-forge/xz-feedstock/issues/1 ).

ocefpaf commented 8 years ago

Note that the update to 5.2.2 is mandatory: the VS solution files do not exist with 5.0.5.

If this is not the right time to update XZ to the newer version, just hold off on merging this PR.

It is. In fact we had that, I deleted due to the Python 3.4/3.5 issues, and I was going to re-add before https://github.com/conda-forge/staged-recipes/pull/370 gets merged.

So :+1:

ccordoba12 commented 8 years ago

Why AppVeyor was not triggered in this case?

ocefpaf commented 8 years ago

Why AppVeyor was not triggered in this case?

The feedstock needs to be re-rendered so the - skip: True # [win] change can propagate to the CI configuration. (Sorry I missed that before @msarahan and thanks @ccordoba12 for noticing it.)

jakirkham commented 8 years ago

You beat me, @ocefpaf, but I'm posting anyways. 😜

It needs to be re-rendered. We disable AppVeyor if there is skip: true # [win] in the recipe.

To fix this, do the following.

conda install -y -n root -c conda-forge conda-smithy
conda smithy rerender
git add .
git commit -m "Re-rendered with conda-smithy x.x.x"
jakirkham commented 8 years ago

...and I beat myself it seems.

ocefpaf commented 8 years ago

...and I beat myself it seems.

The level of activity in conda-forge will drive us all crazyier :stuck_out_tongue_winking_eye: