Add explicit dependency on ffmpeg

conda-forge / yarp-feedstock

A conda-smithy repository for yarp.

BSD 3-Clause "New" or "Revised" License

1 stars 4 forks source link

Add explicit dependency on ffmpeg #13

Closed traversaro closed 2 years ago

traversaro commented 2 years ago

YARP already depends on ffmpeg via opencv, but this dependency is not tracked, even if it is enabled automatically. This PR fixes the situation (see https://github.com/robotology/robotology-superbuild/issues/1296#issuecomment-1293913775). Note that we are not enabling all the devices that depend on ffmpeg due to https://github.com/robotology/yarp/issues/2885 .

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 2 years ago

@conda-forge-admin, please rerender

traversaro commented 2 years ago

YARP already depends on ffmpeg via opencv, but this dependency is not tracked, even if it is enabled automatically. This PR fixes the situation (see https://github.com/robotology/robotology-superbuild/issues/1296#issuecomment-1293913775). Note that we are not enabling all the devices that depend on ffmpeg due to https://github.com/robotology/yarp/issues/2885 .

By the way, probably that was already reported by warnings, so we should give a look to the warnings of conda-build .

traversaro commented 2 years ago

YARP already depends on ffmpeg via opencv, but this dependency is not tracked, even if it is enabled automatically. This PR fixes the situation (see robotology/robotology-superbuild#1296 (comment)). Note that we are not enabling all the devices that depend on ffmpeg due to robotology/yarp#2885 .

By the way, probably that was already reported by warnings, so we should give a look to the warnings of conda-build .

I checked and now the build log is free from warnings related to this.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!