conda-forge / zstd-feedstock

A conda-smithy repository for zstd.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

Migrate to Jinja2 compiler syntax #12

Closed xhochy closed 6 years ago

xhochy commented 6 years ago

An attempt to fix #11

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 6 years ago

One of the Windows patches does not seem to apply anymore fully to rename the artefact. We need extend it before we can merge the PR.

jakirkham commented 6 years ago

Thanks for looking into this, @xhochy :) @rmax, would you have time to look at the patch?

rmax commented 6 years ago

Hey @jakirkham, I did a quick check to see if I could update the patch (by modifying the source and taking a diff) but apparently still fails. Not sure if it has to do with the binary attribute. Any ideas?

jakirkham commented 6 years ago

Was it possible it was upstreamed?