enable pzstd build on Unices

conda-forge / zstd-feedstock

A conda-smithy repository for zstd.

BSD 3-Clause "New" or "Revised" License

2 stars 26 forks source link

enable pzstd build on Unices #13

Closed jvolkening closed 6 years ago

jvolkening commented 6 years ago

zstd doesn't yet thread decompression. In the meantime, pzstd can be incredibly fast when decompressing using multiple cores. This PR enables building pzstd from the contrib directory on Linux/OSX. I don't know how to enable pzstd builds on Windows, or if it is even possible.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

rmax commented 6 years ago

LGTM

igozali commented 1 year ago

Hello, it seems pzstd is removed somewhere between this PR and master since I can't find it on master, curious if anyone knows why that was removed

igozali commented 1 year ago

I think I found the PR that removed pzstd https://github.com/conda-forge/zstd-feedstock/pull/15

jakirkham commented 1 year ago

Could you please raise a new issue and include the info requested in the issue template? This is the most effective way to ensure the issue is tracked and addressable. Thanks! 🙏

igozali commented 1 year ago

yup will do, thank you for replying!

EDIT: done here: https://github.com/conda-forge/zstd-feedstock/issues/76