Remove Whole Program Optimization (/GL) flag disabled by default for …

conda-forge / zstd-feedstock

A conda-smithy repository for zstd.

BSD 3-Clause "New" or "Revised" License

2 stars 26 forks source link

Remove Whole Program Optimization (/GL) flag disabled by default for … #3

Closed maxhora closed 7 years ago

maxhora commented 7 years ago

…VS2015.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rmax commented 7 years ago

Looks good to me.

For reference:

The format of files produced with /GL in the current version may not be readable by subsequent versions of Visual C++. You should not ship a .lib file comprised of .obj files that were produced with /GL unless you are willing to ship copies of the .lib file for all versions of Visual C++ you expect your users to use, now and in the future.

maxhora commented 7 years ago

/GL is enabled for VS2010 projects by default, but in VS2015 it's disabled by default. We use VS project files generated by VS2010 to be built with VS2015, and /GL flag is there. Availability of /GL flag makes the result binaries (at least static lib) be incompatible with any others binaries built with VS2015 with default optimization settings (usually used). I will report issue in official ZStd repo.