conda-forge / zstd-feedstock

A conda-smithy repository for zstd.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

zstd v1.4.5 #40

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/18778, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

rmax commented 4 years ago

Something happened to the dll location 🤔

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>if not exist %PREFIX%\Library\include\zstd.h exit 1 

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>if not exist %PREFIX%\Library\bin\libzstd.dll exit 1 
Tests failed for zstd-1.4.5-h9f78265_0.tar.bz2 - moving package to D:\bld\broken
WARNING:conda_build.build:Tests failed for zstd-1.4.5-h9f78265_0.tar.bz2 - moving package to D:\bld\broken
WARNING conda_build.build:tests_failed(2751): Tests failed for zstd-1.4.5-h9f78265_0.tar.bz2 - moving package to D:\bld\broken
TESTS FAILED: zstd-1.4.5-h9f78265_0.tar.bz2
rmax commented 4 years ago

And another issue in pztd building:

make: Entering directory '$SRC_DIR/contrib/pzstd'
$BUILD_PREFIX/bin/aarch64-conda_cos7-linux-gnu-c++ -MMD -MP -MF main.Td  -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include -I../../lib -I../../lib/common -I../../programs -I. -DNDEBUG -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/zstd-1.4.5 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix  -std=c++11 -c main.cpp  -o main.o
$BUILD_PREFIX/bin/aarch64-conda_cos7-linux-gnu-cc  -MMD -MP -MF util.Td  -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include -I../../lib -I../../lib/common -I../../programs -I. -DNDEBUG -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/zstd-1.4.5 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -O3 -fPIC      -c ../../programs/util.c  -o ../../programs/util.o
../../programs/util.c: In function 'UTIL_setFileStat':
../../programs/util.c:161:24: error: storage size of 'timebuf' isn't known
         struct utimbuf timebuf;
                        ^~~~~~~
../../programs/util.c:164:16: warning: implicit declaration of function 'utime'; did you mean 'ctime'? [-Wimplicit-function-declaration]
         res += utime(filename, &timebuf);
                ^~~~~
                ctime
make: *** [Makefile:250: ../../programs/util.o] Error 1
make: *** Waiting for unfinished jobs....
xhochy commented 4 years ago

Fixed in #41