conda-forge / zstd-feedstock

A conda-smithy repository for zstd.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

Generate and install the pkg-config file on Windows #60

Closed pkgw closed 2 years ago

pkgw commented 2 years ago

Checklist

This edits the Windows MSVC build to generate and install the pkg-config file, which is normally only activated for Unix or Cygwin. This is motivated by conda-forge/libtiff-feedstock#80, where version 4.4 of libtiff changes its pkg-config file to reference a libzstd.pc that doesn't currently exist on Windows. This was in turn discovered in conda-forge/librsvg-feedstock#96, which is currently stuck due to the libtiff update.

After applying this patch, and conda-forge/jpeg-feedstock#36, I can confirm that librsvg starts building again on my test machine.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 2 years ago

@conda-forge-admin, please rerender

hmaarrfk commented 2 years ago

Can you expand the test as well?