search

conda-forge / zstd-feedstock

A conda-smithy repository for zstd.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

[bot-automerge] zstd v1.5.4 #67

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
zstd 1.5.4 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4141002832, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

hmaarrfk commented 1 year ago

did they forget to inclue a fiel?

robquant commented 1 year ago

Their cmake files use the CheckLinkerFlag cmake module which was introduced in CMake 3.18. I just looked through the Linux x64 build log and it seems it installs CMake 3.16.5

hmaarrfk commented 1 year ago

it probably needs https://github.com/conda-forge/cmake-no-system-feedstock/pull/11

hmaarrfk commented 1 year ago

@conda-forge-admin please restart cis

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

hmaarrfk commented 1 year ago

it seems that a similar cmake patch has been used https://github.com/facebook/zstd/commit/a0b09d0ff735d34fd99029bb59ffff2874565b42

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

hmaarrfk commented 1 year ago

ok, i give up.

regro-cf-autotick-bot commented 1 year ago

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/4153063865

jakirkham commented 1 year ago

AFAICT the build script adds linking to rt to LDFLAGS

https://github.com/conda-forge/zstd-feedstock/blob/d0d34ff8c38cb3b8906bfea529d1aa853ffa1368/recipe/install.sh#L7-L10

Though there is some interesting handling for CMake that comes after

https://github.com/conda-forge/zstd-feedstock/blob/d0d34ff8c38cb3b8906bfea529d1aa853ffa1368/recipe/install.sh#L14-L22

It's worth noting upstream has made some changes to how linker flags are handled, which may be why the approach in the recipe is not currently working