Closed djsutherland closed 6 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Are all the patches still necessary? Haven't looked personally just curious to know if we can drop any yet.
Any thoughts on this @rmax?
I didn't really investigate, just noticed that they're all Windows things and the changelog didn't seem to say anything relevant. :)
@jakirkham We can check that in another PR. The two first patches are related to compilation issues in anaconda's VS environment. IIRC, the two last ones are compatibility patches (i.e.: removing optimization flags and keep the naming consistent with the other platforms).
Sure. Didn't mean it as a blocker. Was only curious if this would be a good opportunity to simplify things. :)