search

conda-forge / zstd-feedstock

A conda-smithy repository for zstd.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

zstd 1.5.5 #73

Closed JohanMabille closed 1 year ago

JohanMabille commented 1 year ago

Replaces #69 Fixes #70

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

JohanMabille commented 1 year ago

By default, the symbols of a shared library are not exported on Windows, they are private to the shared lib. If you want to make them publicly visible, you usually declare them with declspec(dllexport) (and use them with declspec(dllimport) on the client side, thus the traditional XX_API macros in classes and functions declarations on Windows).

The problem here is that the symbols that were missing (from common/pool.c and common/threading.c) must not be publicly visible, so the only solution is to add the source file defining them to the executable which needs them.

I have opened a PR upstream to fix this, so hopefully we can remove the patch in the next release.

hmaarrfk commented 1 year ago

Great thanks. with the reference upstream at least there is somebody else knowledgeable in this particular library that has vetted the patch.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!