Open nkaretnikov opened 10 months ago
Discovered this due to https://github.com/conda-incubator/conda-store/issues/666.
I think we can capture the output without having to check the returncode as done in check_output
. IOW:
process = subprocess.run(
[
"fakechroot",
"chroot",
new_root,
"/_conda.exe",
"install",
"--offline",
"--file",
"/opt/conda/pkgs/env.txt",
"-y",
"--prefix",
"/opt/conda",
],
env=env,
cwd=host_conda_opt,
capture_output=True,
text=True,
check=False,
)
And then log the output via process.stdout
and process.stderr
.
That said, we could also look into less hacky ways to build a docker image without docker. These days buildah
, standalone buildkit
and/or podman
might be good alternatives.
Then, about using conda-standalone exe here... it's going to cause trouble one way or another. We could add an option for micromamba
so it actually behaves like a binary.
Currently, it has this comment:
Suggestions: