conda-incubator / conda-project

Tool for encapsulating, running, and reproducing projects with Conda environments
https://conda-incubator.github.io/conda-project/
BSD 3-Clause "New" or "Revised" License
28 stars 11 forks source link

Fix is_consistent again #140

Closed AlbertDeFusco closed 1 year ago

AlbertDeFusco commented 1 year ago

A bug was discovered in the revised is_consistent since the tests had only checked on one platform. The deduplication (necessary when the same package exists in conda and pip lock specs) was being performed globally on the lockfile and would return an incorrect unique collection for the current platform. Moving the filter before deduplication fixes the issue. test_is_installed has been revised to lock for default_platforms rather than the current_platform.

codecov[bot] commented 1 year ago

Codecov Report

Merging #140 (3148a51) into main (fbedab0) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files           9        9           
  Lines         846      846           
=======================================
  Hits          827      827           
  Misses         19       19           
Files Changed Coverage Δ
src/conda_project/project.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more