search

conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 21 forks source link

remove smooth scrolling when the user wants to add a package #218

Closed jujogi closed 1 year ago

jujogi commented 1 year ago

This old approach to scrolling down when the user wants to add a package/channel was causing an issue inside Jupyter Lab. Basically, instead of scrolling the component itself, we should scroll the parent element, which has the ability to do that.

https://user-images.githubusercontent.com/5192743/219144950-a7d5852b-0a57-4300-893f-b1911bb980ae.mov

jujogi commented 1 year ago

@jujogi would you be able to provide a visual of what this PR does? Thanks!

I've always appreciated that from your past PRs 😄. Appoligies if this was already in the works.

@costrouc I just updated the PR's details. I'm glad you like the way I detailed the work :)

jonzeper commented 1 year ago

For comparison, here's the bugged behavior. You can't see it, but i'm trying unsuccessfully to scroll up

https://user-images.githubusercontent.com/803816/219146158-97f6774a-824f-4591-92ca-375e0ba089c8.mp4