conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 21 forks source link

Revisit handling of non-semver package versions #227

Closed jonzeper closed 1 year ago

jonzeper commented 1 year ago

We're filtering out non-semver versions from the version select, but someone could still add a non-semver versioned package in the YAML editor, and that causes a crash when we try to compare it.

anirrudh commented 1 year ago

I'm going to fix the ESLint error here, but this makes sense to me, and I'll add it to the documentation - having the ability to coerce and manually override is a better strategy!

jonzeper commented 1 year ago

Thanks! I got a little confused what the linter's beef was there

anirrudh commented 1 year ago

Hmmm....adding semvers to the yaml causes the build to fail; tried with numpy and pyarrow (0.5.0.pre), is this behavior expected?

jonzeper commented 1 year ago

Not expected. I didn't test extensively, but was able to build an env with pyarrow>=0.5.0pre. Were you able to see a specific error?

anirrudh commented 1 year ago

Nope, just that the env didn't build. But the tests do, and you were able to install! I'm merging - perhaps it's because I did an == instead of >=, just know that mamba fails the build - most likely since it's pretty old. Something to take note of - otherwise, LGTM, merging!