search

conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Optimize whitespace in dependencies widget #262

Closed steff456 closed 1 year ago

steff456 commented 1 year ago

Fixes #242

This PR,

Screenshots

Before

image

After

image

Questions

kcpevey commented 1 year ago

I think because the rest of the UI has so much whitespace, I'd like to add just a little bit back in between the list entries. Maybe just 2 pxs?

Also, the issue also includes the sizing of the widget box. Id like it to be twice as tall as it is right now.

steff456 commented 1 year ago

This is the behavior of the last commit,

scroll

pierrotsmnrd commented 1 year ago

That works for me but I noticed that we were having a different result between the two themes, green-accent and grayscale. The list isn't "dotted" anymore (see screenshots below)

You can switch the color theme by editing your .env file and changing the value for REACT_APP_STYLE_TYPE to any of the following : 

REACT_APP_STYLE_TYPE=green-accent
REACT_APP_STYLE_TYPE=grayscale

I guess that's not the consequence of your PR but the consequence of another PR. Can you check if you find a PR related to this, and fix it so we have a coherent design on both themes please ?

result with green-accent:

green-accent

result with grayscale:

grayscale

steff456 commented 1 year ago

That works for me but I noticed that we were having a different result between the two themes, green-accent and grayscale. The list isn't "dotted" anymore (see screenshots below)

Yes @pierrotsmnrd! I also noticed that the themes don't match. I'll create a new issue for this. I also found that having a box is a little bit weird because I thought they were checkboxes at first. Maybe we need to have a discussion on how we want this to look in both themes.

pierrotsmnrd commented 1 year ago

I agree they look like checkboxes, they should be removed. Ok, open another issue. Once done, you can merge this one. I'm marking it ready for merge

steff456 commented 1 year ago

New issue at: https://github.com/conda-incubator/conda-store-ui/issues/266

Thanks for the review!