search

conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Fix size of requested packages widget #263

Closed steff456 closed 1 year ago

steff456 commented 1 year ago

Fixes #232

This PR,

As this change affects the UI, this are the screenshots on how it changes.

Before

image

After

image

In case the windows is too small to show all the elements, a horizontal scrollbar appears

image
kcpevey commented 1 year ago

@steff456 with these changes, is the behavior that the Requested Packages widget will grow and shrink to fit INSIDE the Specification widget?

You've shown it shrinking down as the Specification widget shrinks. What happens when the Specification widget is bigger than 420?

steff456 commented 1 year ago

is the behavior that the Requested Packages widget will grow and shrink to fit INSIDE the Specification widget?

With these changes, the widget will behave the same as the others under the Specification widget,

232

They will have the main size when there's more room in the interface, and it will shrink to not overflow the specification widget.

anirrudh commented 1 year ago

LGTM, thank you everyone and @pierrotsmnrd for reviewing. I'll be merging this.