conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

[BUG] - Requested Packages is missing full version information #267

Open kcpevey opened 1 year ago

kcpevey commented 1 year ago

Describe the bug

I have an environment spec that has complex version requirements. Only part of the version spec shows up in the Requested Packages field of the UI.

For example, I have the specification

- typing-extensions >= 4.5,!= 4.6

and it shows up in Requested Packages as image

It is missing = 4.6.


The full page looks like this:

image

Expected behavior

I expect the Requested packages field to show the full specification from the yaml syntax

How to Reproduce the problem?

Create a new environment with this yaml spec

channels:
  - conda-forge
  - pytorch
dependencies:
  - python >= 3.8
  - typing-extensions >= 4.5,!= 4.6
  - numpy >= 1.17

  - pillow >= 9.4.0
  - pytorch>=1.7,!=1.12.0
  - torchvision >= 0.14.1
  - datasets >= 2.7.1
  - transformers >= 4.25.1
  - timm >= 0.6.12
  - torchmetrics >= 0.11, < 1.0
  - tqdm>=4.62.1

  # test
  - jupytext >= 1.14.0
  - numpydoc >= 1.5.0
  - pyright >= 1.1.280
  - pytest >= 7.0.0
  - hypothesis >= 6.61.0
  - pytest-mock >= 3.10.0

  - pip:
      - huggingface-hub >= 0.11.1
      - torcheval >= 0.0.6

Output

No response

Versions and dependencies used.

No response

Anything else?

No response

steff456 commented 1 year ago

I've been investigating this issue and I have a working fix for this that looks as expected in view mode,

image

but in edit mode it looks like,

image

Which I believe is a problem with the UX/UI, so maybe this needs more discussions because the editor doesn't allow multiple or complex version requirements.

dharhas commented 1 year ago

The edit mode and view mode should be identical except in the edit mode the constraints are editable.

dharhas commented 1 year ago

Ah I see what you mean. In the original design there was supposed to be the option to type free form text in as well as choosing from the drop down. This will require some UI design.