conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Implement design system inputs #313

Closed steff456 closed 10 months ago

steff456 commented 11 months ago

Part of https://github.com/conda-incubator/conda-store-ui/issues/288

Description

This pull request:

Default

image

Hover

image

Focus

image

Pull request checklist

Additional information

Implemented the first version of the inputs using green for focus

I had to implement the first version of the inputs system that was using the primary color as the focus color because all the components in MUI use either the primary, secondary, warn, info or success colors. The accent color is something we added to the palette but it is not formally defined in the MUI API which means that it will not override by default.

I tried to stick to use the accent color and it was mainly working at first, but later I started to see that there were some other component's focus that were changing as a result of trying to override it,

image

This is not ideal and also the amount of code that was generated by this override will make this very difficult to maintain.

Screenshots

#### Main sidebar image #### Environment dropdown image #### Requested Packages component image #### Channels component image #### New environment **Environment name focused** image **Description focused** image
kcpevey commented 10 months ago

This will need to be reviewed by @smeragoel before merging.