search

conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

conda-store-server version in docker compose should point to a release instead of latest #325

Open dcmcand opened 10 months ago

dcmcand commented 10 months ago

Context

currently, versions of conda-store-server in the docker-compose.yml and docker-compose-dev.yml files point to the latest image tag. This should explicitly be set to point to a release version rather than latest.

Value and/or benefit

By pointing to a specific version rather that latest, we more loosely couple conda-store-server and conda-store-ui. This means that conda-store-ui can release with versions of conda-store-server that are known to be compatible and future releases of conda-store-server won't break the docker-compose setup in the conda-store-ui repo.

Anything else?

No response

costrouc commented 10 months ago

@dcmcand totally agree here. Honestly anything referencing latest IMO is a bug.

nkaretnikov commented 10 months ago

@dcmcand Also agree. We should pin specific versions. I cannot think of any downsides of doing so at the moment.