conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

There's no limit on the sidebar size #329

Open nkaretnikov opened 9 months ago

nkaretnikov commented 9 months ago

Context

If you create an environment with a very long name, the sidebar will scale to accommodate it. I think there should be limit on how big this is rendered. Yes, I understand it's an extreme example, but there might be envs with long names.

Screen Shot 2023-11-04 at 17 35 37

Value and/or benefit

Better UX.

Anything else?

No response

smeragoel commented 9 months ago

image I added an example case for a long environment name. The environment name should be truncated when number of characters is more than 30, and an ellipsis (...) should be appended at the end. The max characters we can display is 30 + ellipsis

nkaretnikov commented 9 months ago

The said truncation should also happen wherever the env name is printed (such as in the tabs bar and above environment metadata). Otherwise, it hides the close tab button (x):

Screen Shot 2023-11-12 at 21 23 26

A quick fixup might be using the max-width: 20px; in CSS, in one of the sidebar divs. This is shown on the screenshot above, but the proposed design above looks way better.