conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Expose `status_info` in the UI #332

Closed nkaretnikov closed 9 months ago

nkaretnikov commented 9 months ago

Companion PR for https://github.com/conda-incubator/conda-store/pull/653

nkaretnikov commented 9 months ago

This shouldn't be merged before the companion PR lands on the server side.

nkaretnikov commented 9 months ago

Looks like this (prints status_info in parens if available - "build_path too long" on the screenshot here):

Before:

Screen Shot 2023-11-07 at 21 38 55

After:

Screen Shot 2023-11-07 at 20 46 10
nkaretnikov commented 9 months ago

This has many changes due to formatting. It helps to hide whitespace when reviewing:

Screen Shot 2023-11-07 at 21 03 27
nkaretnikov commented 9 months ago

@steff456 I still need to figure out why playwright fails, but is this cool overall? UPD: playwright might be just a flaky test, resolved here: #328. @smeragoel Any comments on the design (see screenshot)?

steff456 commented 9 months ago

@nkaretnikov can you please add a screenshot before the change? In that way it is clearer what's the difference in the UI

nkaretnikov commented 9 months ago

@steff456 https://github.com/conda-incubator/conda-store-ui/pull/332#issuecomment-1799796703 Added before/after.

nkaretnikov commented 9 months ago

@steff456 PTAL. Tests now pass, not planning to make more changes.

Do not merge this yet. The companion server PR (https://github.com/conda-incubator/conda-store/pull/653) is not reviewed yet. I'll merge this myself when that one is merged.

nkaretnikov commented 9 months ago
nkaretnikov commented 9 months ago

Before we merge, waiting until the companion PR on the server side is approved.