Tests pass (but with console errors and warnings)

conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react

https://conda-incubator.github.io/conda-store-ui/

BSD 3-Clause "New" or "Revised" License

13 stars 18 forks source link

Tests pass (but with console errors and warnings) #357

Closed gabalafou closed 5 months ago

gabalafou commented 5 months ago

I couldn't find any GitHub issue about the Jest tests being broken.

Description

This pull request:

Allows yarn test to run and exit without errors
(But does not fix any of the uncaught errors that get generated during test execution and logged to the console but do not actually cause any of the tests to fail.)

Pull request checklist

[x] Did you test this change locally?
[x] Did you update the documentation (if required)?
[x] Did you add/update relevant tests for this change (if required)?

trallard commented 5 months ago

(But does not fix any of the uncaught errors that get generated during test execution and logged to the console but do not actually cause any of the tests to fail.)

It seems then we'd need a follow-up more focused PR to fix tests then @gabalafou ?

gabalafou commented 5 months ago

It seems then we'd need a follow-up more focused PR to fix tests then @gabalafou ?

Maybe. Probably. I'll look into it and get back to you.

trallard commented 5 months ago

Thanks, @gabalafou. I will go ahead and merge this.

Per https://github.com/conda-incubator/conda-store-ui/pull/357#issuecomment-1918358880, let's circle back on your findings and make a plan/open issues as needed