Closed nkaretnikov closed 5 months ago
Looked at this locally. After fixing the yarn locking issue, it seems that playwright fails due to a caching issue reported in https://github.com/conda-incubator/conda-store/pull/745. Because this is running in docker, there's already another environment that starts building automatically when the test env is building. The build fails because the cpython dependency gets overwritten in the cache:
So I'm going to fix the caching issue and get back to this later.
Tried setting concurrency
to 1 as a workaround until conda-incubator/conda-store#745 lands, but that causes builds taking too much time.
There might be another issue with buttons timing out on click
s. In chrome dev tools, button-related parts of the DOM are being constantly updated. But it might be due to increased timeouts on builds:
I think it's better to wait until PR 745 lands and seeing if it resolves the issue. When parallel builds are working, there won't be a need for longer timeouts.
Alternatively, we could try disabling all playwright tests for now and enabling unit-tests instead.
Tania asked that this PR only updates the lockfile. Other CI fixes will be in separate PRs.
The CI is expected to be broken here because other issues prevent integration tests from succeeding.
You can see that the lockfile error is resolved here because the message mentioned in the top comment doesn't appear anymore. Here's a different PR where the lockfile issue can be observed if you look at the failed job: https://github.com/conda-incubator/conda-store-ui/pull/370.
We shouldn't merge this just yet. Looks like I've found the issue that causes playwright to fail when this update is applied. I'll share more details later.
Closing because this is now part of https://github.com/conda-incubator/conda-store-ui/pull/372, which fixes all CI issues. All the details are in the linked PR.
Fixes an issue caused by updated dependencies, which manifests on CI as follows:
Description
This pull request: fixes a CI dependency issue.
Pull request checklist
Additional information