conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Add namespace to create environment form #361

Closed gabalafou closed 3 months ago

gabalafou commented 5 months ago

Fixes one half of #307.

Description

This pull request shows the namespace on the form/tab to create a new environment.

Pull request checklist

gabalafou commented 5 months ago

I'm not sure this looks the way we want:

screenshot

Side comment: in that screenshot I'm using the MUI TextField component in disabled mode. That seemed like the most straightforward way to add the namespace to the page. However, the colors on disabled text fields in MUI are low contrast, so I think I should probably re-implement the namespace as something else.

gabalafou commented 4 months ago

@smeragoel when you get a chance could you review this?

smeragoel commented 4 months ago

@gabalafou and I discussed this issue and we decided that we're gonna see how much effort it is to customize the input component to match the designs and then we can decide the way forward

gabalafou commented 4 months ago

Given the conversation in today's planning meeting, I reverted my last commit in favor of using the MUI TextField component without customization

gabalafou commented 4 months ago

The Playwright test is probably a legit failure. Need to investigate.

gabalafou commented 3 months ago

Merged since all checks pass!