search

conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Unit tests are not run on CI #362

Closed nkaretnikov closed 5 months ago

nkaretnikov commented 5 months ago

Context

I've noticed only playwright tests are running. I think unit tests were disabled at some point because there are many failures when I run them locally. Unit tests need to be re-enabled because they have much better coverage compared to playwright tests. Unit tests also make it easier to spot errors early compared to integration tests.

Value and/or benefit

Improved code quality, less bugs, faster dev process.

Anything else?

No response

nkaretnikov commented 5 months ago

Unit tests should be fixed now that https://github.com/conda-incubator/conda-store-ui/pull/357 is merged. But they still need to be enabled on CI.

CC: @gabalafou (this is the CI issue that we've discussed during the team meeting)