conda-incubator / conda-store-ui

conda-store-ui is a frontend for conda-store powered by react
https://conda-incubator.github.io/conda-store-ui/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Remove manual npm publish step #404

Closed pavithraes closed 1 week ago

pavithraes commented 1 month ago

Fixes # .

Description

This pull request:

Removes the manual npm publish steps. This is not required because the release GitHub action has the relevant permission to publish to npm, and it will auto-triggerred when a new tag is created with a release on github.

Pull request checklist

Additional information

peytondmurray commented 1 month ago

One other thing that would be useful to add - there's no mention of merging the release branch back to main, which I think needs to be done before a tag+release is made.

trallard commented 1 month ago

One other thing that would be useful to add - there's no mention of merging the release branch back to main, which I think needs to be done before a tag+release is made.

@peytondmurray I think this is separate and should be in the release checklist itself. I had not added it as it seem clearly implicit but if you prefer we can make that explicit

pavithraes commented 3 weeks ago

I've made the relevant updates. :)

trallard commented 1 week ago

@peytondmurray when ready please merge