DEV - Improve bundling and release

trallard commented 2 months ago

Fixes https://github.com/conda-incubator/conda-store-ui/issues/408

Description

Changes in https://github.com/conda-incubator/conda-store-ui/pull/389 broke the already brittle bundling of conda-store + conda-store-ui.

This pull request:

fixes the ui side of the bundling
simplifies our bundling and
adds some improvements to our webpack.config (and the bundling overall)

Pull request checklist

[x] Did you test this change locally?
[ ] Did you update the documentation (if required)?
[ ] Did you add/update relevant tests for this change (if required)?

Additional information

[!NOTE] I did test this locally, the bundle seems fine and the app works as expected when running the Docker/out-of Docker stuff but I get this warning

WARNING in ./src/index.tsx 2:0-45
export 'IPreferences' (reexported as 'IPreferences') was not found in './preferences' (possible exports: PrefContext, Preferences, prefDefault, prefGlobal)

peytondmurray commented 2 months ago

Ahh, looks like playwright tests aren't passing - there's a Save button it seems to be waiting on.

gabalafou commented 2 months ago

Hopefully PR #422 addresses the Playwright failure

gabalafou commented 2 months ago

@trallard thanks for responding to all of my questions.

I took this PR on three different test drives:

Local dev server build via yarn start
Local server in production-like mode via yarn start:prod
Doing a production build and then opening a static server onto the dist/ directory with python -m http.server -d dist

I clicked around. I logged in, logged out. I didn't kick off any new builds or create any new environments, but I don't see how this PR would affect that.

So I doubt the Playwright failure is related, but if we want to be safe we could try merging in #422 first and then rebasing this PR.

conda-incubator / conda-store-ui