search

conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
143 stars 46 forks source link

[BUG] - conda-store image needs a release target and dev target in the Dockerfile #614

Closed dcmcand closed 11 months ago

dcmcand commented 11 months ago

Describe the bug

Split from #599

conda-store, which does an editable install:

conda-store/conda-store/Dockerfile

Lines 22 to 23 in 64552a2 RUN cd /opt/conda-store && \ pip install -e .

❗️this is also the file used during releases which should not be the case

Expected behavior

To fix this, refactor conda-store/Dockerfile to have 2 different build targets.

  1. The dev target should install dependencies in editable mode as the the current file does
  2. The release target should not install dependencies in editable mode
  3. The .github/workflows/build_docker_image.yaml workflow should be changed to use the release target

How to Reproduce the problem?

N/A

Output

No response

Versions and dependencies used.

No response

Anything else?

No response

dcmcand commented 11 months ago

I am working on this one.