conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
143 stars 46 forks source link

remove extra redis and move to using built images for examples #620

Closed dcmcand closed 11 months ago

dcmcand commented 11 months ago

Fixes #616 Fixes #617 Part of #599

Description

Updates docker-compose files in examples directory

This pull request:

Pull request checklist

netlify[bot] commented 11 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit d70fd4d78ccdabd061da27083f71d866e6849e34
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6528577356037200093c0c9a
costrouc commented 11 months ago

@dcmcand I'll be honest this is a set of examples I haven't tested in a LONG time. Actually all of the examples haven't been tested in awhile. The docker-compose.yaml in the root of the repository is the most tested.

Should we be testing examples?

dcmcand commented 11 months ago

I think that examples should be tested. I know when I start using a new project, I often use the example as a getting started place. If they aren't tested and don't work, that would be pretty frustrating.