search

conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
143 stars 46 forks source link

Windows support #640

Closed nkaretnikov closed 10 months ago

nkaretnikov commented 10 months ago

See #507. Original PR: #559.

netlify[bot] commented 10 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit 0ad9f5a05daaa9426b4eff0df264e03b51dde560
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6535884c8aeac10008e44bba
nkaretnikov commented 10 months ago

Removed some original CI changes while rebasing, since main uses miniforge.

nkaretnikov commented 10 months ago

Note: Windows test takes 25 min. macOS: 14 min. Ubuntu: 10 min.

I wonder why that is. E.g., the post set up env on Windows takes 3 mins, while it takes 4 secs on macOS. Is this disk/fs perf? Other phases are also slower by 2 mins on average.

nkaretnikov commented 10 months ago

Manually tested this env via the admin UI:

channels:
- conda-forge
dependencies:
- python
- pip:
  - nothing
- ipykernel
- pytest
- requests
description: ''
name: test-env
prefix: null
variables: null

Building, rebuilding, and deletion work.

nkaretnikov commented 10 months ago

@costrouc This is Aaron's Windows PR with some minor changes from me. PTAL and merge if OK.

jaimergp commented 10 months ago

the post set up env on Windows takes 3 mins

You can do run-post: false (or similar name) on setup-miniconda. It's an ephemeral VM after all.