replace port 5000 with port 8080

conda-incubator / conda-store

Data science environments, for collaboration. ✨

https://conda.store

BSD 3-Clause "New" or "Revised" License

143 stars 46 forks source link

replace port 5000 with port 8080 #642

Closed dcmcand closed 10 months ago

dcmcand commented 10 months ago

Fixes #618 .

Description

Replaces port 5000 with port 8080 as the default port to run on. Port 8080 is not a privileged port, but is an alternate port for HTTP. Port 5000 is in use on some Mac computers which causes conflicts.

This pull request:

Replaces port 5000 with port 8080 as default port.

Pull request checklist

[x] Did you test this change locally?
[X] Did you update the documentation (if required)?
[X] Did you add/update relevant tests for this change (if required)?

Additional information

netlify[bot] commented 10 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name	Link
Latest commit	90f22ee7e50b7902478c81b3a2a65a5d8dabf310
Latest deploy log	https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/653c08a0d2bd3d0008e1a18c

costrouc commented 10 months ago

This may cause a breaking change in the client's etc. assuming port 5000 by default but I'm unsure. Most clients use 80/443 with a proper installation. But I know a lot of the development assumptions in clients use 5000.

kcpevey commented 10 months ago

This may cause a breaking change in the client's etc. assuming port 5000 by default but I'm unsure.

We'll need to make a note in the release notes.

nkaretnikov commented 10 months ago

Have you tested this with conda-store-ui? For me, this breaks the login process (when you click on the Login button) when using conda-store-ui. Because the UI assumes port 5000 for conda-store. I'll open an issue on the UI side.

Also, port 8080 is what conda-store-ui has been using.