search

conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
142 stars 46 forks source link

Change `url_prefix` to `/conda-store` #647

Closed nkaretnikov closed 10 months ago

nkaretnikov commented 10 months ago

This is what conda-store-ui expects, which allows running conda-store-server in standalone mode without passing the config.

Fixes #646.

netlify[bot] commented 10 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit 82e6805ca767ba7954a3f3e0bf10ba5562ec6ffb
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/653ff9557a9d930008bacdc8
nkaretnikov commented 10 months ago

With this PR, it's now possible to just do python -m conda_store_server.server --standalone and use the Login button on the homepage, which is served by conda-store-ui. Tested on Windows and Linux. See the issue for details and this comment https://github.com/conda-incubator/conda-store-ui/issues/322#issuecomment-1785488710.

Note: this branch is based on main, but I removed the port change commit, which prevents this from working by default, see https://github.com/conda-incubator/conda-store-ui/issues/322. When this PR lands, the port issue still won't be solved, so this won't work by default. But on this particular branch everything works fine.

costrouc commented 10 months ago

@nkaretnikov I'm surprised this is needed. For the typical install I would expect url_prefix to be /. The only reason /conda-store is used is since this is required for deployments with multiple services under the same domain. We can meet to talk about this if you'd like?

nkaretnikov commented 10 months ago

Discussed this offline. A better solution would be to do this on the UI side. The /conda-store prefix exists mostly for running within Nebari.