Closed nkaretnikov closed 9 months ago
Name | Link |
---|---|
Latest commit | 36da8f04e00674b25241ad06e958420148209a4f |
Latest deploy log | https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6565c0c56f5375000822bf08 |
TODO:
[x] Add build_key_version
to Build
ORM
[x] An API test for this:
http://localhost:8080/conda-store/api/v1/build/1/yaml/
which is accessed via Show yml file
in the UI. this will redirect to full path in storage using the build key [x] A unit test for this:
build_key
works with different Build
versionsparse_build_key
parses build id correctly with build keys from different build versions.Seems fine. Still need to do the final review and test locally.
Manual tests I did (as of commit 738f650):
This is currently blocked due to an upstream test hanging (or taking too long?) (unrelated to this PR): https://github.com/conda-incubator/conda-store/issues/666
I'll try to fix the upstream issue first before opening this for review.
Do not get misled by "All checks have passed" here. The problematic test was skipped.
@jaimergp Updated, PTAL. Added a command-line/config parameter, now users can switch between v1 and v2 if needed. By default the short hash version is used. With the new default, old environments are still accessible in the UI.
@jaimergp Addressed your feedback, PTAL
@jaimergp PTAL. Replied to all of your comments. Only made a change to the docs.
Fixes #611.