Closed nkaretnikov closed 9 months ago
Name | Link |
---|---|
Latest commit | e2a7618c14249f86c186812214c710f1f543a5a7 |
Latest deploy log | https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65511ef73490960008ffc55d |
TODO:
schema.BuildStatus.FAILED
doesn't contain an error message. I'll see if this can be added easily.This PR should be merged first since it has new tests, which are useful. I think it will conflict with #652 because it uses a migration (migration hashes won't match). #531 might require rebasing as well.
Companion PR on the UI side (see screenshot there): https://github.com/conda-incubator/conda-store-ui/pull/332
I think we can afford to be more detailed here, but I don't know if that's the correct place. Maybe just codifying the error type with an identifier+number we can add some documentation on how to work around this issue?
I initially printed the whole path and its size, too. But that'd be flaky on CI because different directories are used everywhere. It also seems like an implementation detail, which is not helpful unless you have admin rights. I'll just add documentation for now and we can improve later.
Hey @jaimergp, thanks for your comments! I'm going to document the build_path
in docs/administration.md
, similar to how we document the MAX_PATH
issue on Windows. Otherwise, I don't think there's a need to change anything else.
UPD: Added documentation.
@jaimergp is this ready for merge? if so then perhaps you and/or @nkaretnikov should open a follow-up issue with potential improvements or areas to explore and merge this straight away
Fixes #649.