conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
142 stars 46 forks source link

Disable code that depends on conda-docker #667

Closed nkaretnikov closed 9 months ago

nkaretnikov commented 9 months ago

See #666.

netlify[bot] commented 9 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit a566e7d9aa21c77a01e6200d9fcfe439ac7bc331
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/655ddf3bc09e520008e1d4d6
costrouc commented 9 months ago

The conda-store docker bits are not well maintained at this moment. I would be fine with merging this but would like us to have a plan for if in the future we would like to support this. This feature is powerful since it allows conda-store to build docker images of environments without docker/root but I would say was largely an experiment.

nkaretnikov commented 9 months ago

@costrouc I'm planning to fix the upstream issue in conda-docker ASAP. There are some suggestions from Jaime to try, but I cannot say anything concrete since I haven't tried anything yet.

@jaimergp Updated. I've used the same message everywhere that we have elsewhere instead of the "Temporary" one. I also don't like the word "temporary" since it's somewhat meaningless (everything is temporary to some extent). I think the other message conveys the intention to support this feature in the future as well. Using the same message in the warning and error will also make it easier to discover both once people search for one of them. I also use a full URL instead of an issue number to make it easier to understand which repo this refers to.