conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
142 stars 46 forks source link

Place a bound on docker-py #689

Closed nkaretnikov closed 8 months ago

nkaretnikov commented 9 months ago

A new version of docker-py was released and it now causes issues with docker-compose because the latter doesn't work with the new version. This PR adds a bound to make sure the versions are compatible.

New version that causes problems:

docker-py                             7.0.0  pyhd8ed1ab_0        conda-forge/noarch

Old version that works:

docker-py                             6.1.3  pyhd8ed1ab_0        conda-forge/noarch

This error was printed on CI during Tests / integration-test conda-store-server (pull_request):

Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/test/bin/docker-compose", line 11, in <module>
    sys.exit(main())
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/main.py", line 81, in main
    command_func()
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/main.py", line 200, in perform_command
    project = project_from_options('.', options)
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/command.py", line 60, in project_from_options
    return get_project(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/command.py", line 152, in get_project
    client = get_client(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/docker_client.py", line 41, in get_client
    client = docker_client(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/docker_client.py", line 124, in docker_client
    kwargs = kwargs_from_env(environment=environment, ssl_version=tls_version)
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
Error: Process completed with exit code 1.
netlify[bot] commented 9 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit 39b8bf3edcf12673378946edcef3e4cda21871ed
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6574fb77d209700008c5e9da
nkaretnikov commented 9 months ago

This is the same commit as upstream/main, but CI now fails in Tests / integration-test conda-store-server (pull_request):

Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/test/bin/docker-compose", line 11, in <module>
    sys.exit(main())
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/main.py", line 81, in main
    command_func()
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/main.py", line 200, in perform_command
    project = project_from_options('.', options)
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/command.py", line 60, in project_from_options
    return get_project(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/command.py", line 152, in get_project
    client = get_client(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/docker_client.py", line 41, in get_client
    client = docker_client(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/docker_client.py", line 124, in docker_client
    kwargs = kwargs_from_env(environment=environment, ssl_version=tls_version)
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
Error: Process completed with exit code 1.

Looks like docker-py updated and it now causes issues with docker-compose because the latter doesn't work with the new version.

This PR vs the most recently merged role mappings PR:

new
1339:2023-12-09T22:38:53.6916382Z   + docker-py                             7.0.0  pyhd8ed1ab_0        conda-forge/noarch       103kB

old
885:2023-11-30T10:01:04.9457116Z   + docker-py                             6.1.3  pyhd8ed1ab_0        conda-forge/noarch       104kB
nkaretnikov commented 8 months ago

This is ready for review.